[fix] #4267: Introduce p2p idle timeout #4398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Erigara
added
Bug
|
Waiting for @BAStos525 conformation that issue is resolved to undraft PR. |
BAStos525
force-pushed
the
connected_peers
branch
from
9379f24 to
0bf8164
Compare
|
Got confirmation that issue is resolved. |
Erigara
requested review from
s8sato,
mversic,
Arjentix,
SamHSmith,
outoftardis,
0x009922,
DCNick3,
VAmuzing and
Asem-Abdelhady
as code owners
DCNick3
reviewed
Apr 2, 2024
Erigara
force-pushed
the
connected_peers
branch
2 times, most recently
from
433ae50 to
2499098
Compare
DCNick3
previously approved these changes
Apr 3, 2024
|
Need to update config snapshots it seems |
github-actions
bot
added
the
config-changes
0x009922
reviewed
Apr 4, 2024
0x009922
previously approved these changes
Apr 4, 2024
Signed-off-by: Shanin Roman <[email protected]>
0x009922
approved these changes
Apr 5, 2024
DCNick3
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously iroha tried to connect indefinitely to idle peer.
Introduce idle timeout for p2p communication:
Each peer track the last time it received message (or ping) from particular peer, if this time is larger than timeout peer is disconnected.
If no other messages were produced in time equal to half timeout ping is send to prove that peer isn't idle.
Linked issue
Closes #4267
How to test
LOGLEVEL=TRACE ./scripts/test_env.py setupnc -l 1338